Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle last_modified only in FileLoader #232

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented Jan 3, 2024

Fixes #230.

  • last_modified is only handled in FileLoader, not in the rooms.
  • File observers now only notify about out-of-band changes (rooms don't care about changes they are responsible for). As such, there is no argument to pass to callbacks.
  • load_content effectively loads the content, thus the content parameter has been removed.
  • save_content has been removed since it is not used.
  • The shielded file save operation must be awaited even if the task that awaits it is cancelled, otherwise the file may be saved and last_modified not updated.
  • notify has been renamed to maybe_notify, as it only notifies about out-of-band changes (it was previously notifying every second even if the file didn't change).
  • A file save operation must be awaited if cancelled.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Binder 👈 Launch a Binder on branch davidbrochart/jupyter_collaboration/fix-saving

@davidbrochart davidbrochart added bug Something isn't working enhancement New feature or request labels Jan 3, 2024
@davidbrochart davidbrochart force-pushed the fix-saving branch 4 times, most recently from d2bb673 to 8dd3307 Compare January 3, 2024 15:55
@davidbrochart davidbrochart merged commit d4ec54a into jupyterlab:main Jan 3, 2024
21 checks passed
@davidbrochart davidbrochart deleted the fix-saving branch January 3, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outputs stop being streamed
1 participant