Skip to content

Commit

Permalink
ui test for baseurl issue
Browse files Browse the repository at this point in the history
  • Loading branch information
Meriem-BenIsmail committed Nov 25, 2024
1 parent d3c394d commit a128e05
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 26 deletions.
6 changes: 1 addition & 5 deletions ui-tests/jupyter_server_test_config_timeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,10 @@
"""Server configuration for integration tests.
!! Never use this configuration in production because it
opens the server to the world and provides access to JupyterLab
opens the server to the world and provide access to JupyterLab
JavaScript objects through the global window variable.
"""
import os
from tempfile import mkdtemp
from typing import Any
import logging


from jupyterlab.galata import configure_jupyter_server

Expand Down
30 changes: 9 additions & 21 deletions ui-tests/playwright.timeline.config.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
const fs = require('fs');
const path = require('path');
const baseConfig = require('@jupyterlab/galata/lib/playwright-config');

// Directory for timeline tests
const timelineTestDir = path.resolve(
process.env.TIMELINE_TEST_DIR || '/tmp/galata-timeline-tests'
);
/*
* Copyright (c) Jupyter Development Team.
* Distributed under the terms of the Modified BSD License.
*/

// Ensure the test directory exists
if (!fs.existsSync(timelineTestDir)) {
fs.mkdirSync(timelineTestDir, { recursive: true });
console.log(`Created timeline test directory: ${timelineTestDir}`);
}
/**
* Configuration for Playwright using default from @jupyterlab/galata
*/
const baseConfig = require('@jupyterlab/galata/lib/playwright-config');

module.exports = {
...baseConfig,
Expand All @@ -32,14 +27,7 @@ module.exports = {
name: 'timeline-tests',
testMatch: 'tests/**/timeline-*.spec.ts',
testIgnore: '**/.ipynb_checkpoints/**',
retries: process.env.CI ? 2 : 0,
timeout: 90000,
use: {
launchOptions: {
slowMo: 30,
},
tmpPath: timelineTestDir, // Set dynamic tmpPath
},
timeout: 120 * 1000,
},
],
};

0 comments on commit a128e05

Please sign in to comment.