Skip to content

Commit

Permalink
Fix writing settings in page_config
Browse files Browse the repository at this point in the history
  • Loading branch information
fcollonval authored May 7, 2024
1 parent 7100c29 commit 22dfb17
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions projects/jupyter-server-ydoc/jupyter_server_ydoc/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,9 @@ def initialize_settings(self):
)

def initialize_handlers(self):
self.serverapp.web_app.settings.setdefault(
"page_config_data",
{
"disableRTC": self.disable_rtc,
"serverSideExecution": self.server_side_execution,
},
)
page_config = self.serverapp.web_app.settings.setdefault("page_config_data", {})
page_config.setdefault("disableRTC", self.disable_rtc)
page_config.setdefault("serverSideExecution", self.server_side_execution)

# Set configurable parameters to YStore class
for k, v in self.config.get(self.ystore_class.__name__, {}).items():
Expand Down

0 comments on commit 22dfb17

Please sign in to comment.