-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Azure Open AI Embeddings to Jupyter AI #940
Add support for Azure Open AI Embeddings to Jupyter AI #940
Conversation
Can someone please add the label to this PR? I am not seeing the option. Maybe because I do not have contributor/owner access. |
It would also be nice if someone can point to the necessary literature to add support for deployment names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsrikant7 Thanks so much for opening this PR! I have reviewed the code changes and tested your branch and checked that the drop down menus now correctly show the required fields and options.
However, I do not have an API key for an Azure account, so cannot test if it works as intended with /learn
and then with '/ask. Would you be able to add screenshots to demonstrate that the enhancement works as intended? (Show that the embedding model has learned a single doc and that
/ask` delivers answers showing that the document information has been retrieved and presented in the response.)
Thanks for reviewing. I have tested this and have shared the screenshot @srdas |
Hi! I am getting this error when trying /learn on Azure:
I have created a deployment of text-embedding-ada-002 named text-embedding-ada-002. Normal interaction works, so API key and endpoint is correctly set. |
@bjornarfjelldal I had the same issue. If you set the environmental variable |
Hi, @albertmichaelj ! I forgot to mention that in the previous post, but I've tried to set
|
You will have to set the environmental variable when launching the Docker container. This can be done from the |
* Add support for Azure Open AI Embeddings to jupyter AI * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Srikant Garnaik <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This PR adds Azure Open AI embeddings provider to be able to use embedding use cases like
/learn
fromjupyter-ai
UI.Related issue - #349
Caveats: It expects that the
model_id
and thedeployment_name
are same for the embeddings model. It currently does not support custom deployment names.For example, to use
text-embedding-ada-002
embedding model, create a deployment with nametext-embedding-ada-002
and use it.