Address error on /learn after change of embedding model
#870
Conversation
There was a problem hiding this comment.
@srdas
Thanks for fixing this. It might be better to make the default in learn_dir as False, which is the most used option. Also, it seems like that relearn which indexes the files in case the embedding model is changed, should save the all_files option initially passed from the user.
For an immediate fix, let's make all_files default as False, long term let's figure out how to persist the all_files option passed by the user, so that relearn works in the intended way when model is changed.
@3coins As suggested, the default in |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
srdas
force-pushed
the
change_embedding_learn
branch
from
0357d96 to
7a1f4f0
Compare
…#870) * Address error on `/learn` after change of embedding model. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Set `all_files` option to default to False * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Fixes Issue #869
The
all_filesparameter was not being passed to learn the RAG folder when the embedding provider is changed. This has now been fixed and tested. To test, an initial embedding model is used and/learnis applied.(See Issue #869 for the error that is addressed below.)
Next, the embedding model is changed on the settings page and
/learnis tested again to make sure it is working as expected, as shown: