Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix send via keyboard after sending slash command with arguments #850

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Jun 21, 2024

Fixes #849.

  • The highlighted state variable tracks whether any slash command option is highlighted. When highlighted is true, we disable sending via keyboard to allow the 'Enter' key to select a slash command option to be selected via 'Enter'.
  • This PR ensures that within the ChatInput component, the highlighted state variable is never true if the popup menu is closed. This means that whenever the popup menu is closed, 'Enter' will always send the user message.

@dlqqq dlqqq added the bug Something isn't working label Jun 21, 2024
@dlqqq dlqqq force-pushed the fix-sending-chat branch from 7664a6c to f50355e Compare June 21, 2024 15:56
@dlqqq dlqqq merged commit 37dc8ec into jupyterlab:main Jun 21, 2024
8 checks passed
@dlqqq dlqqq deleted the fix-sending-chat branch June 21, 2024 16:49
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot send via keyboard after using slash command with an argument
2 participants