Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clear slash command to use HelpChatHandler to reinstate the help menu #846

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

srdas
Copy link
Collaborator

@srdas srdas commented Jun 20, 2024

Partially related to Issue #616
Also related to: #842 (comment)

Builds the message in the help handler and then uses it after clearing chat. This replaces the earlier version that was re-using the previous chat history to build the message.

Before /clear:
image

After /clear:
image

Verified also by examining the histories exported via /export.

@srdas srdas requested review from 3coins and removed request for 3coins June 20, 2024 19:00
@srdas srdas added the enhancement New feature or request label Jun 20, 2024
@srdas srdas changed the title Update /clear' to use HelpChatHandler` to reinstate the help menu Update clear slash command to use HelpChatHandler to reinstate the help menu Jun 20, 2024
srdas and others added 2 commits June 20, 2024 13:48
Builds the message in the help handler and then uses it after clearing chat.
@3coins 3coins force-pushed the clear_chat_with_help branch from 30e8b74 to d417329 Compare June 20, 2024 20:48
@srdas srdas merged commit f5eef88 into jupyterlab:main Jun 20, 2024
8 checks passed
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
…e help menu (jupyterlab#846)

* Update `/clear' to use `Handler`

Builds the message in the help handler and then uses it after clearing chat.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request @jupyter-ai/chatui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants