Fix Azure OpenAI authentication from UI #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeill
approved these changes
May 20, 2024
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* fix Azure OpenAI authentication from UI * pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Azure OpenAI authentication from the UI. This issue arises from this line in LangChain: https://github.com/langchain-ai/langchain/blob/f2579096993ae460516a0aae1d3e09f3eb5c1772/libs/partners/openai/langchain_openai/llms/azure.py#L89
Previously, we assumed the keyword parameter was the same as the auth environment variable name in lowercase. However,
AzureOpenAIexpects theAZURE_OPENAI_API_KEYenvironment variable but theopenai_api_keykeyword parameter. This PR adds a newkeyword_param: Optional[str]field toEnvAuthStrategyto specify that a different keyword parameter should be used than the default we assume.Also removes unused imports in
providers.py.Closes #214.