Handle single files, pdfs, errors from missing loader dependencies in /learn
#733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) Enables handling single files, not just directories. (2) Learns PDFs with langchain's PyPDFLoader. (3) Gives a clean error w/o traceback when the file type that is being handled needs addtional packages.
for more information, see https://pre-commit.ci
3coins
reviewed
Apr 16, 2024
Removed the extra attribute and additional response comments based on feedback from Piyush Jain and Andrii Ieroshenko
…//github.com/srdas/jupyter-ai into handle_single-files_pdfs_install-pypdf-error
3coins
reviewed
Apr 16, 2024
Made the error message more generic as there are many different failure types.
|
@srdas pip install pre-commit
pre-commit install |
3coins
approved these changes
Apr 16, 2024
|
Thanks @3coins for your support. |
|
@meeseeksdev please backport to 1.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
dlqqq
pushed a commit
to dlqqq/jupyter-ai
that referenced
this pull request
Apr 25, 2024
…ssing loader dependencies in `/learn`
dlqqq
added a commit
that referenced
this pull request
Apr 25, 2024
…er dependencies in `/learn` (#744) Co-authored-by: Sanjiv Das <[email protected]>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
… `/learn` (jupyterlab#733) * Handle single files, pdfs, errors (1) Enables handling single files, not just directories. (2) Learns PDFs with langchain's PyPDFLoader. (3) Gives a clean error w/o traceback when the file type that is being handled needs addtional packages. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * error handling for missing packages in learn.py Removed the extra attribute and additional response comments based on feedback from Piyush Jain and Andrii Ieroshenko * Amend error message for failure in learn.py Made the error message more generic as there are many different failure types. * Fixed build error. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Piyush Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves on PR #712
This PR makes the following enhancements:
PyPDFLoader. In PR Handle Single Files and also enable html, pdf file formats for /learn #712, thepypdfpackage was directly used instead ofPyPDFLoader, which also depends onpypdf.pypdfwas added as a required dependency, this has been changed to make it an optional dependency in [all].pypdfis not installed, the full missing package error with traceback is displayed, which is poor UX. Modifiedlearn.pyto return a clean error with the missing package name, w/o traceback. The error handling for a missing dependency is generic and does not depend on specific packages, and is displayed when the file type that is being handled needs additional packages.Here is an example of the error when
pypdfis not installed.Here is an example of handling a single PDF file after
pypdfis installed.