Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Anthropic Claude 3 models to providers #672

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

srdas
Copy link
Collaborator

@srdas srdas commented Mar 5, 2024

Modified the Bedrock and BedrockChat models in providers.py to remove all v1 models and added the Claude-3-Sonnet model.

Added comments directing developers to the Amazon Docs where provider model ids are listed.

Copy link

welcome bot commented Mar 5, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@dlqqq dlqqq added the enhancement New feature or request label Mar 5, 2024
@dlqqq dlqqq force-pushed the modify-claude-items branch from 41620ec to e337e3a Compare March 7, 2024 19:04
@dlqqq dlqqq changed the title Update anthropic models Add Anthropic Claude 3 models to providers Mar 7, 2024
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you!

@dlqqq dlqqq marked this pull request as ready for review March 7, 2024 19:33
@dlqqq dlqqq enabled auto-merge (squash) March 7, 2024 19:33
@dlqqq dlqqq merged commit 1b5d1c9 into jupyterlab:main Mar 7, 2024
9 checks passed
Copy link

welcome bot commented Mar 7, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@srdas srdas deleted the modify-claude-items branch March 11, 2024 21:02
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
* update anthropic models

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update anthropic models

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* update anthropic models

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update anthropic models

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the list of provided Anthropic and Bedrock models Add support for Claude V3 models on AWS Bedrock
2 participants