Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAI text-embedding-3-small, -large models #628

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

JasonWeill
Copy link
Collaborator

Adds two new 3rd-generation (gen-3) embedding models for OpenAI embeddings: text-embedding-3-small and text-embedding-3-large.

When I try to select and use one of the new models, it works, but I get a warning: Warning: model not found. Using cl100k_base encoding. This comes from tiktoken and is fixed by openai/tiktoken#247, which uses the same cl100k_base encoding as mentioned in the warning.

@JasonWeill JasonWeill added enhancement New feature or request @jupyter-ai/chatui labels Feb 7, 2024
@JasonWeill JasonWeill linked an issue Feb 7, 2024 that may be closed by this pull request
@JasonWeill JasonWeill force-pushed the openai-gen3-embedding branch from 51b7e35 to b4bd2c3 Compare February 7, 2024 23:22
@JasonWeill JasonWeill enabled auto-merge (squash) February 7, 2024 23:22
@JasonWeill JasonWeill merged commit 1b1e5ca into jupyterlab:main Feb 7, 2024
8 checks passed
@JasonWeill
Copy link
Collaborator Author

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter-ai that referenced this pull request Feb 7, 2024
JasonWeill added a commit that referenced this pull request Feb 7, 2024
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
* Adds new gen-3 embedding models

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* Adds new gen-3 embedding models

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request @jupyter-ai/chatui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OpenAI text-embedding-3-small, -large models
2 participants