-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect theme changes without a refresh #575
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
@garsonbyte Thank you so much for opening this! It looks like the linting test is failing. Can you try running |
73b289d
to
d47f56c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garsonbyte Thank you so much for working on this! This issue had totally escaped my attention. Your PR worked great out-of-the-box. 🎉
There were a few additional changes that I wanted to make to your branch before merging. I've submitted these as a pull request on your fork: garsonbyte#1
If you're OK with these suggestions, then please merge that PR, which will include those commits in this PR. Then I'll approve and merge this PR. 👍
By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals and rebuild the theme object in response. This allows CSS variable changes to reflect in the MUI theme without having to refresh the page.
03a0569
to
c14d819
Compare
@garsonbyte Sorry for the delay in merging your PR. I rebased the branch onto the latest version of BTW, you should add your Git email to your GitHub profile so your avatar shows up in the commit history. Right now, only my avatar is showing, even though you authored the first commit. The email you used to sign your commit is |
@meeseeksdev please backport to 1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
* Reflect theme changes without a refresh By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals and rebuild the theme object in response. This allows CSS variable changes to reflect in the MUI theme without having to refresh the page. * update yarn.lock * pass themeManager as a prop instead of using top-level scope * remove theme hack added in jupyterlab#192 --------- Co-authored-by: gchow <[email protected]> Co-authored-by: David L. Qiu <[email protected]> (cherry picked from commit ca03e2c)
* Reflect theme changes without a refresh By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals and rebuild the theme object in response. This allows CSS variable changes to reflect in the MUI theme without having to refresh the page. * update yarn.lock * pass themeManager as a prop instead of using top-level scope * remove theme hack added in jupyterlab#192 --------- Co-authored-by: gchow <[email protected]> Co-authored-by: David L. Qiu <[email protected]> (cherry picked from commit ca03e2c)
* Reflect theme changes without a refresh By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals and rebuild the theme object in response. This allows CSS variable changes to reflect in the MUI theme without having to refresh the page. * update yarn.lock * pass themeManager as a prop instead of using top-level scope * remove theme hack added in #192 --------- Co-authored-by: gchow <[email protected]> Co-authored-by: David L. Qiu <[email protected]> (cherry picked from commit ca03e2c) Co-authored-by: Garson R Chow <[email protected]>
* Reflect theme changes without a refresh By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals and rebuild the theme object in response. This allows CSS variable changes to reflect in the MUI theme without having to refresh the page. * update yarn.lock * pass themeManager as a prop instead of using top-level scope * remove theme hack added in jupyterlab#192 --------- Co-authored-by: gchow <[email protected]> Co-authored-by: David L. Qiu <[email protected]>
* Reflect theme changes without a refresh By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals and rebuild the theme object in response. This allows CSS variable changes to reflect in the MUI theme without having to refresh the page. * update yarn.lock * pass themeManager as a prop instead of using top-level scope * remove theme hack added in jupyterlab#192 --------- Co-authored-by: gchow <[email protected]> Co-authored-by: David L. Qiu <[email protected]>
By leveraging
IThemeManager.themeChanged
, we can listen on theme change signals and rebuild the theme object in response. This allows CSS variable changes to reflect in the MUI theme without having to refresh the page.(@dlqqq) I've verified that this PR: