Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document entry point and API for custom embedding models #533

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

krassowski
Copy link
Member

References

Fixes #518

Code changes

  • adds a minimal working example to the docs
  • export BaseEmbeddingsProvider to match BaseProvider which is already exported (and avoid exposing embedding_providers module which can be treated as implementation detail)

User-facing changes

None

Breaking changes

None

@krassowski krassowski added the documentation Improvements or additions to documentation label Dec 20, 2023
@krassowski krassowski marked this pull request as ready for review December 20, 2023 18:53
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM! You are a champion 🙌

@dlqqq dlqqq merged commit 32bb264 into jupyterlab:main Dec 20, 2023
7 checks passed
@dlqqq
Copy link
Member

dlqqq commented Dec 20, 2023

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter-ai that referenced this pull request Dec 20, 2023
dlqqq pushed a commit that referenced this pull request Dec 20, 2023
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for BaseEmbeddingsProvider
2 participants