Dynamically generate help message for slash commands in chat UI #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeill
force-pushed
the
dynamic-help
branch
from
6bdd40d to
de0ca5e
Compare
|
Thank you so much for opening this PR! I think the approach is good, although I think that having both the |
|
Thank you @JasonWeill, done in 0eb021d. |
JasonWeill
approved these changes
Dec 19, 2023
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Dec 19, 2023
…sh commands in chat UI
JasonWeill
pushed a commit
that referenced
this pull request
Dec 19, 2023
…s in chat UI (#526) Co-authored-by: Michał Krassowski <[email protected]>
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
…terlab#520) * Show help for custom slash commands * Morph `short_help` into existing `help` per review
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
…terlab#520) * Show help for custom slash commands * Morph `short_help` into existing `help` per review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #436
There already was
helpproperty which was not used, but it was populated with longer sentences, for example:helpattribute: "Clears the displayed chat message history only; does not clear the context sent to chat providers"I can imagine that in the future we could have
/help learnwhich would use the long version, so I am proposingshort_helpto prefer in the chat UI summary message shown on/help.However, this does not have to be this way, here are some alternative options which sound good to me to:
helpas being the "short help" and rename oldhelptolong_helpsummaryordescriptionfor "short help" keeping oldhelpas-isUser-facing changes
No changes, unless user has a custom command installed, in which case these show up after the default commands but before
/help: