-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect user preferred dir and allow to configure logs dir #490
Conversation
c80431b
to
014576e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krassowski
Thanks for working on this change. I have one comment about the logs dir name, looks good otherwise.
@krassowski Thanks for your patience on this PR! Could you please rebase this change against |
0f6d175
to
bc4b5fe
Compare
Done @JasonWeill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krassowski
Thanks for making the updates. LGTM!
Thank you both! |
@meeseeksdev please backport to 1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
This PR:
/generate
error logs #487/generate
should write to--preferred-dir
or current dir, nor--root-dir
#488