Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run check-release on release #477

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

hegdeadithyak
Copy link
Contributor

@hegdeadithyak hegdeadithyak commented Nov 17, 2023

This pull request removes the unnecessary check-release step when running a release. This will improve the release process by reducing the time it takes to complete.

Fixes #404

Copy link

welcome bot commented Nov 17, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adithya4720 Thank you! Just one minor comment.

.github/workflows/check-release.yml Outdated Show resolved Hide resolved
@dlqqq dlqqq added the maintenance Change related to maintenance of the repository label Nov 17, 2023
.github/workflows/check-release.yml Outdated Show resolved Hide resolved
@hegdeadithyak hegdeadithyak requested a review from dlqqq November 19, 2023 00:24
@hegdeadithyak
Copy link
Contributor Author

@dlqqq Can you review this

@dlqqq dlqqq merged commit 9382352 into jupyterlab:main Nov 21, 2023
6 checks passed
Copy link

welcome bot commented Nov 21, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@dlqqq
Copy link
Member

dlqqq commented Nov 21, 2023

@Adithya4720 Awesome work!

@dlqqq
Copy link
Member

dlqqq commented Nov 21, 2023

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter-ai that referenced this pull request Nov 21, 2023
dlqqq pushed a commit that referenced this pull request Nov 21, 2023
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
* Don't run check-release on release

* Don't run check-release on release

* Don't run check-release on release

* Deleted Debug
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* Don't run check-release on release

* Don't run check-release on release

* Don't run check-release on release

* Deleted Debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Change related to maintenance of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run check-release on release
2 participants