Skip to content

Commit

Permalink
Run unit tests as a part of CI (#519)
Browse files Browse the repository at this point in the history
* Add ci step to run unit tests

* Skip test_forbid_write_write_conflict as flakey

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Comments per @dlqqq

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
andrii-i and pre-commit-ci[bot] authored Dec 18, 2023
1 parent 976f8b9 commit aca80b7
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
30 changes: 30 additions & 0 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Python Unit Tests

# suppress warning raised by https://github.com/jupyter/jupyter_core/pull/292
env:
JUPYTER_PLATFORM_DIRS: "1"

on:
push:
branches: main
pull_request:
branches: "*"

jobs:
unit-tests:
name: Linux
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Install extension dependencies and build the extension
run: ./scripts/install.sh

- name: Execute unit tests
run: |
set -eux
pytest -vv -r ap --cov jupyter_ai
2 changes: 2 additions & 0 deletions packages/jupyter-ai/jupyter_ai/tests/test_config_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,8 @@ def test_update_after_describe(cm: ConfigManager):
assert new_config.model_provider_id == "cohere:medium"


# TODO: make the test work on Linux including CI.
@pytest.mark.skip(reason="Flakey on Linux including CI.")
def test_forbid_write_write_conflict(cm: ConfigManager):
configure_to_openai(cm)
# call DescribeConfig
Expand Down

0 comments on commit aca80b7

Please sign in to comment.