Skip to content

Commit

Permalink
Don't execute server from playwright
Browse files Browse the repository at this point in the history
Apply fix from 55fa89c
  • Loading branch information
fcollonval committed Oct 10, 2023
1 parent 18008cb commit a6e0a13
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 11 deletions.
21 changes: 21 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,11 @@ jobs:
run: |
set -eux
python -m pip install "jupyterlab>=4.0.0,<5" jupyterlab_search_replace*.whl
- name: Launch JupyterLab
run: |
jlpm start 2>&1 > /tmp/jupyterlab_server.log &
working-directory: ui-tests

- name: Install dependencies
working-directory: ui-tests
Expand All @@ -143,6 +148,12 @@ jobs:
run: jlpm playwright install chromium
working-directory: ui-tests

- name: Wait for JupyterLab
uses: ifaxity/[email protected]
with:
resource: http-get://localhost:8888/lab
timeout: 360000

- name: Execute integration tests
working-directory: ui-tests
run: |
Expand All @@ -157,6 +168,16 @@ jobs:
ui-tests/test-results
ui-tests/playwright-report
- name: Stop JupyterLab
if: always()
run: |
pkill -s SIGTERM jupyter-lab
- name: Print JupyterLab logs
if: always()
run: |
cat /tmp/jupyterlab_server.log
check_links:
name: Check Links
runs-on: ubuntu-latest
Expand Down
12 changes: 1 addition & 11 deletions ui-tests/playwright.config.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,4 @@
/**
* Configuration for Playwright using default from @jupyterlab/galata
*/
const baseConfig = require('@jupyterlab/galata/lib/playwright-config');

module.exports = {
...baseConfig,
webServer: {
command: 'jlpm start',
url: 'http://localhost:8888/lab',
timeout: 120 * 1000,
reuseExistingServer: !process.env.CI
}
};
module.exports = require('@jupyterlab/galata/lib/playwright-config');

0 comments on commit a6e0a13

Please sign in to comment.