Skip to content

Commit

Permalink
Fix integration test
Browse files Browse the repository at this point in the history
  • Loading branch information
fcollonval committed Oct 11, 2023
1 parent 0cf640c commit 152abad
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
4 changes: 2 additions & 2 deletions ui-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"test:update": "jlpm playwright test --update-snapshots"
},
"devDependencies": {
"@jupyterlab/galata": "^5.0.5",
"@playwright/test": "^1.37.0"
"@jupyterlab/galata": "^5.0.6",
"@playwright/test": "^1.38.1"
}
}
3 changes: 2 additions & 1 deletion ui-tests/tests/search.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ test('should get 5 matches', async ({ page, tmpPath }) => {
);

// Check the match is selected in the editor
await expect(page.locator('::selection')).toHaveText(
await page.getByLabel('conftest.py').getByRole('textbox').waitFor();
expect(await page.evaluate(() => `${window.getSelection()}`)).toEqual(
'strange'
);
});
Expand Down
8 changes: 4 additions & 4 deletions ui-tests/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ __metadata:
languageName: node
linkType: hard

"@jupyterlab/galata@npm:^5.0.5":
"@jupyterlab/galata@npm:^5.0.6":
version: 5.0.6
resolution: "@jupyterlab/galata@npm:5.0.6"
dependencies:
Expand Down Expand Up @@ -1279,7 +1279,7 @@ __metadata:
languageName: node
linkType: hard

"@playwright/test@npm:^1.32.2, @playwright/test@npm:^1.37.0":
"@playwright/test@npm:^1.32.2, @playwright/test@npm:^1.38.1":
version: 1.38.1
resolution: "@playwright/test@npm:1.38.1"
dependencies:
Expand Down Expand Up @@ -2779,8 +2779,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "jupyterlab-search-replace-ui-tests@workspace:."
dependencies:
"@jupyterlab/galata": ^5.0.5
"@playwright/test": ^1.37.0
"@jupyterlab/galata": ^5.0.6
"@playwright/test": ^1.38.1
languageName: unknown
linkType: soft

Expand Down

0 comments on commit 152abad

Please sign in to comment.