-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecations for v2 upgrades #154
Conversation
avoid using generic `kv_` prefix for _not_ generic config like url, username, password
can sublass :class:`TKvProxy`. | ||
""" | ||
|
||
kv_client = Any() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed these generic traits from KVProxy which weren't actually generic - these are unused by the base class and not actually general, even though our two subclasses have sufficiently similar setups.
I traded them for more descriptive and specific etcd_username
, etc. config on the specific implementation classes, since these should be implementation-specific details, not generic features.
avoid unnecessary breakage by leaving old names available with deprecation warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @minrk
I cancelled the etcd workflow that kept running now, 4 hours in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides having a test issue that needs to be addressed, this LGTM! I also figured its useful to have the deprecations listed in the PR description, so I added what I understand them to be so please review that edit I made also.
Resolve or understand the test hanging to be unrelated and this LGTM!
Thanks! Hang was the result of merging a few test changes, seems to be all good now. |
There's still a run in progress actually, been going 5 hours and counting: https://github.com/jupyterhub/traefik-proxy/actions/runs/4241217403 |
Adds deprecated aliases for the APIs that were removed in #145
should prevent unnecessary breakage while folks upgrade
closes #149
Deprecations
TraefikConsulProxy class
kv_url
is deprecated, useconsul_url
kv_username
is deprecated, useconsul_username
kv_password
is deprecated, useconsul_password
TraefikEtcdProxy class
kv_url
is deprecated, useetcd_url
kv_username
is deprecated, useetcd_username
kv_password
is deprecated, useetcd_password
TraefikTomlProxy class
TraefikFileProviderProxy
insteadtoml_dynamic_config_file
is deprecated, usedynamic_config_file
instead. YAML is also supported.TraefikProxy class (all classes)
toml_static_config_file
is deprecated, usestatic_config_file
. YAML is also supported.