-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a donate button to the banner #2160
Conversation
What do you think about making the call to action "donate .." or something else that makes it clear this isn't about "supporting" in the many ways that is possible with open-source projects but only about money? My thinking was that in the context of an open-source project my first thought isn't "financial donation" when I see a "support this project" link. Instead I expect it to contain information about PRs, bugs, forum, how to contribute, etc and maybe info about donations. This made me think shouldd we make the label of the button super obviously about "helping with cash", so that those who are looking for a button like that know to click it? The main goal would be to make it easier to find the button if you are looking for it. |
mybinder/values.yaml
Outdated
<div style="flex:1;text-align:center;"> | ||
Thanks to <a href="https://cloud.google.com/">Google Cloud</a>, <a href="https://www.ovh.com/">OVH</a>, <a href="https://notebooks.gesis.org">GESIS Notebooks</a> and the <a href="https://turing.ac.uk">Turing Institute</a> for supporting us! 🎉 | ||
</div> | ||
<a class="btn-submit" style="width:fit-content;height:fit-content;padding:10px;font-weight:bold;margin-top:-10px;" href="https://numfocus.salsalabs.org/donate-to-binder" target="_blank"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btn btn-primary
has better contrast, if you want to try that
mybinder/values.yaml
Outdated
<div style="flex:1;text-align:center;"> | ||
Thanks to <a href="https://cloud.google.com/">Google Cloud</a>, <a href="https://www.ovh.com/">OVH</a>, <a href="https://notebooks.gesis.org">GESIS Notebooks</a> and the <a href="https://turing.ac.uk">Turing Institute</a> for supporting us! 🎉 | ||
</div> | ||
<a class="btn-submit" style="width:fit-content;height:fit-content;padding:10px;font-weight:bold;margin-top:-10px;" href="https://numfocus.salsalabs.org/donate-to-binder" target="_blank"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the link should be to @choldgraf's new support My Binder page?
re: colors, we could try Binder's tertiary color (the pinkish reddish color) - that may stand out a bit more? I also agree we should add a little icon to it, like a heart or a "pray" emoji or something like that. I'm 50/50 on whether it's better to direct to the "support binder" page in our docs, vs. just going straight to a donation page. On one hand, the |
Question: Should we list "supporters of mybinder.org" on this home page, or use our support page for this? |
I tried @choldgraf's suggestion of using the other mybinder colours With a slight darkening onmouseover (difficult to see side by side, but obvious when it changes under your cursor): Not sure either about whether to go straight to the donation page or to go to the about pages... Also I've update the text as @betatim suggested |
Nice! Thanks for these updates - a few quick thoughts:
|
I agree with your assessment (also, thanks so much for putting them all together). I think in the name of simplicity, my vote would be for pink with white heart |
I'll also update the binder docs with a button of the same style once we finalize something, so we can have some consistency |
👍 to pink with white |
This should be ready now! Unless we want to try and implement this by overriding a template (jupyterhub/binderhub#1472). It would be much cleaner since we could hopefully use CSS classes, including the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - we can iterate later to improve things as well, IMO (e.g., when we add a below-the-fold list of supporters?)
If there's a "better" implementation and you'd like to do that instead of this one, I'm fine with that too now that we know the look-and-feel of the button that we'd like, but don't want to block progress just because there's a slightly better way to do it :-)
I don't know exactly how to convert this to a template override in the Helm chart.... if no-one else can quickly convert it then probably best to leave it for the future? |
Hmmm - I didn't realize that the button was flush with the top of the screen...I feel like it would be better if it were centered with the other banner content. I'm not sure how to do this with BinderHub CSS, but I think these are the rules we'd need: #banner-container {
padding: 8px; /* To prevent the container from being much bigger */
}
#banner-container > div {
align-items: center; /* Center all items in the div vertically */
}
#banner-container .btn {
margin-top: unset; /* to cause centering via the flexbox rather than manually specifying.
} |
@choldgraf That was intentional, the default header css has We can't override the parent container CSS using a style in |
Actually another option could be a new |
Attempting to add a donate button (#2156)
This is based on the launch button but white on yellow isn't very visible (which is perhaps also a problem for the launch button!)