Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use novnc 1.5.0 #123

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Update to use novnc 1.5.0 #123

merged 1 commit into from
Jul 12, 2024

Conversation

manics
Copy link
Member

@manics manics commented Jul 12, 2024

1.4.0 has two copies of rfb.js

  • node_modules/@novnc/novnc/core/rfb.js
  • node_modules/@novnc/novnc/lib/rfb.js

1.5.0 only has one copy:

Closes #117

1.4.0 has two copies of `rfb.js`
- `node_modules/@novnc/novnc/core/rfb.js`
- `node_modules/@novnc/novnc/lib/rfb.js`
1.5.0 only has one copy:
- `node_modules/@novnc/novnc/lib/rfb.js`
- novnc/noVNC@b35cf6d
Copy link

Binder 👈 Launch a binder notebook on this branch for commit db42535

I will automatically update this comment whenever this PR is modified

@yuvipanda yuvipanda changed the title novnc 1.5.0 Update to use novnc 1.5.0 Jul 12, 2024
@yuvipanda yuvipanda merged commit f3a6b1b into jupyterhub:main Jul 12, 2024
7 checks passed
@yuvipanda
Copy link
Contributor

Nicely done, @manics

@manics manics deleted the novnc-1.5.0 branch July 12, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build/install fails with novnc/novnc 1.5.0
3 participants