-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Skip Link to Notebook #6844
Conversation
Thanks @seirani! Looks like there are a few lint issues that should be fixed when running |
Likely we could update the tests to remove the notebook/packages/application/test/shell.spec.ts Lines 32 to 35 in 787339c
And maybe check the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes one of the tasks on #6800
Problem: "No skip link found (keyboard-only users have to tab 20 times every time to get to main region to do work)."
Changes to Code: Added a SkipLink widget
To Fix: Fails test case checking that all areas are empty by default. Skip to Link is only functional for Notebook page, not for Tree header page (where I wasn't sure what the desired "main" content to skip to should be)
Without using the skip link: User has to click through every single tab in the menu before reaching the edit feature of the first cell.
without-skip-link.mov
With the functional skip link: User tabs to "Skip to Main" first, then can click enter to go directly to the first cell edit.
with-skiplink.mov