Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of the "EditTextbox" is missing: #3977 #4744

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Name of the "EditTextbox" is missing: #3977 #4744

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab56f9d
Fixes issue#3977 by adding the aria-label attribute
fabihaahmed Jun 28, 2019
f986bf7
Made a small change as requested in the PR
fabihaahmed Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions notebook/static/notebook/js/celltoolbarpresets/tags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ define([
"is treated as tag separators.");

var textarea = $('<textarea/>')
.attr('aria-label', 'Edit the tags in the text area')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.attr('aria-label', 'Edit the tags in the text area')
.attr('aria-label', i18n.msg._('Edit the tags in the text area'))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will make it localizable, so users in other languages will hear it in their own language

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I have made the necessary changes.

.attr('rows', '13')
.attr('cols', '80')
.attr('name', 'tags')
Expand Down