Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h1 heading for dialog: issue #3936 #4684

Closed
wants to merge 2 commits into from
Closed

h1 heading for dialog: issue #3936 #4684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df97de7
3936: I have fixed this issue and the popup now has title as h1 like …
joshuazeltser Jun 7, 2019
ac39b23
added bower fix
joshuazeltser Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
"marked": "~0.5",
"MathJax": "^2.7.4",
"moment": "~2.19.3",
"preact": "https://unpkg.com/preact@^7.2.0/dist/preact.min.js",
"preact-compat": "https://unpkg.com/preact-compat@^3.14.3/dist/preact-compat.min.js",
"proptypes": "https://unpkg.com/proptypes@^0.14.4/index.js",
"preact": "https://unpkg.com/preact@~7.2.0/dist/preact.min.js",
"preact-compat": "https://unpkg.com/preact-compat@~3.14.3/dist/preact-compat.min.js",
"proptypes": "https://unpkg.com/proptypes@~0.14.4/index.js",
"requirejs": "~2.2",
"requirejs-text": "~2.0.15",
"requirejs-plugins": "~1.0.3",
Expand Down
5 changes: 2 additions & 3 deletions notebook/static/base/js/dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ define(['jquery',
.attr("aria-hidden", "true")
.html("×")
).append(
$("<h4/>")
.addClass('modal-title')
.text(options.title || "")
options.type ? options.type.addClass('modal-title').text(options.title || "")
: $("<h4/>").addClass('modal-title').text(options.title || "")
)
).append(
$("<div/>")
Expand Down
1 change: 1 addition & 0 deletions notebook/static/notebook/js/notebook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1577,6 +1577,7 @@ define([
notebook: this,
keyboard_manager: this.keyboard_manager,
title : i18n.msg._("Use markdown headings"),
type : $("<h1/>"),
body : $("<p/>").text(
i18n.msg._('Jupyter no longer uses special heading cells. ' +
'Instead, write your headings in Markdown cells using # characters:')
Expand Down