uclixnjupyternbaccessibility issue fixes 1

.gitignore

@@ -41,3 +41,4 @@ config.rst
 
 package-lock.json
 geckodriver.log
+*.ipynb

azure-pipelines.yml

@@ -0,0 +1,100 @@
+
+variables:
+  JUPYTER_TEST_BROWSER: firefox
+  MOZ_HEADLESS: 1
+
+pool:
+  vmImage: 'ubuntu-latest'
+
+steps:
+- task: UsePythonVersion@0
+  inputs:
+    versionSpec: '3.6'
+    addToPath: true
+    architecture: 'x64'
+
+- script: |
+      pip install --upgrade pip
+      pip install --upgrade setuptools wheel nose coverage codecov
+      nvm install 6.9.2
+      nvm use 6.9.2
+      node --version
+      npm --version
+      npm upgrade -g npm
+      npm install
+      git clone git://github.com/n1k0/casperjs.git
+      cd casperjs
+      sudo ln -sf `pwd`/bin/casperjs /usr/local/bin/casperjs
+      cd ..
+      echo 'casperjs and phantomjs installed'
+      sudo apt-get install libc6 libstdc++6 libgcc1 libgtk2.0-0 libasound2 libxrender1 libdbus-glib-1-2
+      sudo apt-get install firefox
+      echo 'FIREFOX INSTALLED'
+      wget https://github.com/laurentj/slimerjs/releases/download/1.0.0/slimerjs-1.0.0.tar.bz2
+      tar -xvjf slimerjs-1.0.0.tar.bz2
+      sudo mv slimerjs-1.0.0 /usr/local/share
+      sudo ln -sf /usr/local/share/slimerjs-1.0.0/slimerjs /usr/local/bin
+      export SLIMERJSLAUNCHER=/usr/bin/firefox
+      pip install -r docs/doc-requirements.txt
+      pip install --upgrade pytest
+      pip install --upgrade selenium pytest
+      wget https://github.com/mozilla/geckodriver/releases/download/v0.19.1/geckodriver-v0.19.1-linux64.tar.gz
+      mkdir geckodriver
+      tar -xzf geckodriver-v0.19.1-linux64.tar.gz -C geckodriver
+      cd geckodriver
+      sudo cp geckodriver /usr/local/bin
+      cd ..
+      #   export PATH=$PATH:$PWD/geckodriver
+      npm install sqlite3
+      pip install "attrs>=17.4.0"
+  displayName: 'Before Install'
+  continueOnError: false
+
+- script: |
+      pip install --pre .[test] $EXTRA_PIP
+      pip freeze
+      wget https://github.com/jgm/pandoc/releases/download/1.19.1/pandoc-1.19.1-1-amd64.deb
+      sudo dpkg -i pandoc-1.19.1-1-amd64.deb
+  displayName: 'Install'
+  continueOnError: false
+
+- script: |
+      jupyter kernelspec list
+      symlinks=$(find . -type l| grep -v './node_modules/' | grep -v './git-hooks')
+      if [[ $(echo $symlinks) ]]; then
+          echo "Repository contains symlinks which won't work on windows:"
+          echo $symlinks
+          echo ""
+          false
+      else
+          true
+      fi
+      python -m notebook.jstest base
+  displayName: 'Run base Tests'
+  continueOnError: false
+
+- script: |
+      python -m notebook.jstest notebook
+  displayName: 'Run notebook Tests'
+  continueOnError: false
+
+# - script: |
+#       python -m notebook.jstest services
+#   displayName: 'Run services Tests'
+#   continueOnError: false
+
+- script: |
+      nosetests -v --exclude-dir notebook/tests/selenium --with-coverage --cover-package=notebook notebook
+  displayName: 'Run coverage Tests'
+  continueOnError: false
+
+# - script: |
+#       py.test -sv notebook/tests/selenium
+#   displayName: 'Run selenium Tests'
+#   continueOnError: false
+
+- script: |
+      make -C docs/ html
+      pytest --nbval --current-env docs
+  displayName: 'Run documentation Tests'
+  continueOnError: false

notebook/static/acc_overwrite.less

@@ -0,0 +1,54 @@
+//This is file created for overwriting some of bootstrap element color in order to satisfiy the color contrast greater than 4.5:1.
+
+.btn-danger{
+    color: #ffffff;
+    background-color: #df0404;
+    border-color: #df0404;
+}
+
+.btn-warning{
+    color: #ffffff;
+    background-color:#b46102;
+    border-color: #b46102;
+}
+
+@link-color: #296eaa;
+
+.close {
+    float: right;
+    font-size: (@font-size-base * 1.5);
+    font-weight: @close-font-weight;
+    line-height: 1;
+    color: @close-color;
+    text-shadow: @close-text-shadow;
+    .opacity(.6);
+
+    &:hover,
+    &:focus {
+      color: @close-color;
+      text-decoration: none;
+      cursor: pointer;
+      .opacity(1.0);
+}  button& {
+    padding: 0;
+    cursor: pointer;
+    background: transparent;
+    border: 0;
+    -webkit-appearance: none;
+    appearance: none;
+  }
+}
+
+.navbar-nav {
+    > li > a {
+      color: @navbar-default-link-color;
+      // To make keyboard focus clearly visible on the Controls(File,Edit,View,Insert,Cell...etc)present on the menubar.
+      //&:hover, //To use browser's hover default value 
+      &:focus {
+      /* -webkit-focus-ring-color = '#5B9DD9' */
+      outline: -webkit-focus-ring-color auto 5px;
+     // color: @navbar-default-link-hover-color;
+     // background-color: @navbar-default-link-hover-bg;
+      }
+    }
+    }

notebook/static/auth/css/override.css

@@ -5,4 +5,4 @@ a hack to deal with our current css styles and no new styling should be added in
 #ipython-main-app {
     padding-top: 50px;
     text-align: center;
-}
+}

notebook/static/base/js/dialog.js

@@ -60,14 +60,14 @@ define(['jquery',
                 })
                 .append($("<button>")
                     .attr("type", "button")
+                    .attr("aria-label","close")
                     .addClass("close")
                     .attr("data-dismiss", "modal")
                     .attr("aria-hidden", "true")
                     .html("&times;")
                 ).append(
-                    $("<h4/>")
-                        .addClass('modal-title')
-                        .text(options.title || "")
+                    options.type ? options.type.addClass('modal-title').text(options.title || "")
+                        : $("<h4/>").addClass('modal-title').text(options.title || "")
                 )
         ).append(
             $("<div/>")

notebook/static/base/js/namespace.js

@@ -1,83 +1,83 @@
-// Copyright (c) Jupyter Development Team.
-// Distributed under the terms of the Modified BSD License.
-
-
-var Jupyter = Jupyter || {};
-
-var jprop = function(name, module_path){
-    Object.defineProperty(Jupyter, name, {
-      get: function() { 
-          console.warn('accessing `'+name+'` is deprecated. Use `requirejs("'+module_path+'")`');
-          return requirejs(module_path); 
-      },
-      enumerable: true,
-      configurable: false
-    });
-}
-
-var jglobal = function(name, module_path){
-    Object.defineProperty(Jupyter, name, {
-      get: function() { 
-          console.warn('accessing `'+name+'` is deprecated. Use `requirejs("'+module_path+'").'+name+'`');
-          return requirejs(module_path)[name]; 
-      },
-      enumerable: true,
-      configurable: false
-    });
-}
-
-define(function(){
-    "use strict";
-
-    // expose modules
-
-    jprop('utils','base/js/utils')
-
-    //Jupyter.load_extensions = Jupyter.utils.load_extensions;
-    // 
-    jprop('security','base/js/security');
-    jprop('keyboard','base/js/keyboard');
-    jprop('dialog','base/js/dialog');
-    jprop('mathjaxutils','notebook/js/mathjaxutils');
-
-
-    //// exposed constructors
-    jglobal('CommManager','services/kernels/comm')
-    jglobal('Comm','services/kernels/comm')
-
-    jglobal('NotificationWidget','base/js/notificationwidget');
-    jglobal('Kernel','services/kernels/kernel');
-    jglobal('Session','services/sessions/session');
-    jglobal('LoginWidget','auth/js/loginwidget');
-    jglobal('Page','base/js/page');
-
-    // notebook
-    jglobal('TextCell','notebook/js/textcell');
-    jglobal('OutputArea','notebook/js/outputarea');
-    jglobal('KeyboardManager','notebook/js/keyboardmanager');
-    jglobal('Completer','notebook/js/completer');
-    jglobal('Notebook','notebook/js/notebook');
-    jglobal('Tooltip','notebook/js/tooltip');
-    jglobal('Toolbar','notebook/js/toolbar');
-    jglobal('SaveWidget','notebook/js/savewidget');
-    jglobal('Pager','notebook/js/pager');
-    jglobal('QuickHelp','notebook/js/quickhelp');
-    jglobal('MarkdownCell','notebook/js/textcell');
-    jglobal('RawCell','notebook/js/textcell');
-    jglobal('Cell','notebook/js/cell');
-    jglobal('MainToolBar','notebook/js/maintoolbar');
-    jglobal('NotebookNotificationArea','notebook/js/notificationarea');
-    jglobal('NotebookTour', 'notebook/js/tour');
-    jglobal('MenuBar', 'notebook/js/menubar');
-
-    // tree
-    jglobal('SessionList','tree/js/sessionlist');
-
-    Jupyter.version = "6.0.0.dev0";
-    Jupyter._target = '_blank';
-
-    return Jupyter;
-});
-
-// deprecated since 4.0, remove in 5+
-var IPython = Jupyter;
+// Copyright (c) Jupyter Development Team.
+// Distributed under the terms of the Modified BSD License.
+
+
+var Jupyter = Jupyter || {};
+
+var jprop = function(name, module_path){
+    Object.defineProperty(Jupyter, name, {
+      get: function() { 
+          console.warn('accessing `'+name+'` is deprecated. Use `requirejs("'+module_path+'")`');
+          return requirejs(module_path); 
+      },
+      enumerable: true,
+      configurable: false
+    });
+}
+
+var jglobal = function(name, module_path){
+    Object.defineProperty(Jupyter, name, {
+      get: function() { 
+          console.warn('accessing `'+name+'` is deprecated. Use `requirejs("'+module_path+'").'+name+'`');
+          return requirejs(module_path)[name]; 
+      },
+      enumerable: true,
+      configurable: false
+    });
+}
+
+define(function(){
+    "use strict";
+
+    // expose modules
+    
+    jprop('utils','base/js/utils')
+    
+    //Jupyter.load_extensions = Jupyter.utils.load_extensions;
+    // 
+    jprop('security','base/js/security');
+    jprop('keyboard','base/js/keyboard');
+    jprop('dialog','base/js/dialog');
+    jprop('mathjaxutils','notebook/js/mathjaxutils');
+
+
+    //// exposed constructors
+    jglobal('CommManager','services/kernels/comm')
+    jglobal('Comm','services/kernels/comm')
+
+    jglobal('NotificationWidget','base/js/notificationwidget');
+    jglobal('Kernel','services/kernels/kernel');
+    jglobal('Session','services/sessions/session');
+    jglobal('LoginWidget','auth/js/loginwidget');
+    jglobal('Page','base/js/page');
+
+    // notebook
+    jglobal('TextCell','notebook/js/textcell');
+    jglobal('OutputArea','notebook/js/outputarea');
+    jglobal('KeyboardManager','notebook/js/keyboardmanager');
+    jglobal('Completer','notebook/js/completer');
+    jglobal('Notebook','notebook/js/notebook');
+    jglobal('Tooltip','notebook/js/tooltip');
+    jglobal('Toolbar','notebook/js/toolbar');
+    jglobal('SaveWidget','notebook/js/savewidget');
+    jglobal('Pager','notebook/js/pager');
+    jglobal('QuickHelp','notebook/js/quickhelp');
+    jglobal('MarkdownCell','notebook/js/textcell');
+    jglobal('RawCell','notebook/js/textcell');
+    jglobal('Cell','notebook/js/cell');
+    jglobal('MainToolBar','notebook/js/maintoolbar');
+    jglobal('NotebookNotificationArea','notebook/js/notificationarea');
+    jglobal('NotebookTour', 'notebook/js/tour');
+    jglobal('MenuBar', 'notebook/js/menubar');
+
+    // tree
+    jglobal('SessionList','tree/js/sessionlist');
+
+    Jupyter.version = "6.0.0.dev0";
+    Jupyter._target = '_blank';
+
+    return Jupyter;
+});
+
+// deprecated since 4.0, remove in 5+
+var IPython = Jupyter;

notebook/static/notebook/js/maintoolbar.js

@@ -73,6 +73,8 @@ define([
         var multiselect = $('<option/>').attr('value','multiselect').attr('disabled','').text('-');
         var sel = $('<select/>')
             .attr('id','cell_type')
+            .attr('aria-label', 'combobox, select cell type')
+            .attr('role', 'combobox')
             .addClass('form-control select-xs')
             .append($('<option/>').attr('value','code').text(i18n.msg._('Code')))
             .append($('<option/>').attr('value','markdown').text(i18n.msg._('Markdown')))

notebook/static/notebook/js/menubar.js

@@ -404,6 +404,7 @@ define([
             var about = $("#notebook_about").parent();
             divider = $("<li>")
                 .attr('id', "kernel-help-links")
+                .attr('role', "none")
                 .addClass('divider');
             about.prev().before(divider);
         }
@@ -421,6 +422,7 @@ define([
             cursor.after($("<li>")
                 .append($("<a>")
                     .attr('target', '_blank')
+                    .attr('role', "menuitem")
                     .attr('title', i18n.msg._('Opens in a new window'))
                     .attr('href', requirejs.toUrl(link.url))
                     .append($("<i>")