Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent file descriptor leak in util.just_run #237

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Prevent file descriptor leak in util.just_run #237

wants to merge 5 commits into from

Commits on Jun 28, 2022

  1. Add a test ensuring that just_run doesn't leak fds

    @mariokostelac
    mariokostelac committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    9a877a1 View commit details
    Browse the repository at this point in the history

  2. Make sure just_run doesn't leak file descriptors of new loops.

    @mariokostelac
    mariokostelac committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    818f2a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Update nbclient/tests/test_util.py 

    Co-authored-by: David Brochart <[email protected]>
    @mario-at-intercom @davidbrochart
    mario-at-intercom and davidbrochart authored Jun 29, 2022
    Configuration menu
    Copy the full SHA
    47283dc View commit details
    Browse the repository at this point in the history

  2. Call sleep without helper function

    @mariokostelac
    mariokostelac committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    fbf02e9 View commit details
    Browse the repository at this point in the history

  3. Rewrite test to avoid mypy issues

    @mariokostelac
    mariokostelac committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    11fea9b View commit details
    Browse the repository at this point in the history