Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to CoC enforcement #199

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Conversation

JasonWeill
Copy link
Contributor

Fixes a broken link from governance/conduct/code_of_conduct.md to …/enforcement.md, as first observed by @adriens in jupyterlab/jupyter-ai#577 (comment) — thanks!

@krassowski
Copy link
Member

I don't believe the link is broken when deployed on https://jupyter.org/governance/conduct/code_of_conduct.html and would worry that it could possibly break with this change. It is just not meant to be used on GitHub - see that all other links are without .md

@JasonWeill
Copy link
Contributor Author

I did find two links that already ended in .md:

This one is properly transformed to .html in the published docs:

confidential. Code of Conduct reports are currently reviewed by the [Executive Council](../executive_council.md). In some cases we may determine that a public statement will need

This one is not; "standard procedure" renders as regular text, not as a link:

[standard procedure](enforcement.md#Resolutions) to arrive at and

@JasonWeill
Copy link
Contributor Author

Fixed the latter link above to link to a page; linking to a named anchor doesn't seem to be supported. Tested locally.

@JasonWeill
Copy link
Contributor Author

Thank you @willingc ! I don't have write access to this repository. Would you be able to merge this change in, please?

@blink1073 blink1073 merged commit f223232 into jupyter:main Jan 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants