-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JEP: Add Jupyter Book as subproject #123
Conversation
Is there any discussion or questions that we need to answer to move this forward? How can we make progress on this? |
This JEP should be discussed during the SSC working hours today (according to the triage last week). I think it has been opened long enough so that we can move it to the voting phase. |
This JEP has been discussed in the pre-JEP issue, there were Q&A sessions during the SSC working hours, it's time to move to the voting phase. |
Since adding a subproject to Jupyter requires both SSC and EC approval (as Fernando mentioned here), we discussed this briefly in the EC meeting today. Since the SSC is already voting on this proposal, we (the EC) will wait to see the result of this vote. As a next step, if this is approved, the EC asks that a PR be opened to the governance repo adding the subproject to the official list of subprojects, and the EC can officially vote on the subproject addition in that governance PR. |
I marked @minrk as "yes" because he approved the PR. I think only @gabalafou remains. For the decision, am I correct in my understanding from the governance docs that this only requires a majority vote from the SSC? This is what I'm basing this on: https://jupyter.org/governance/decision_making.html#required-aspects-of-decision-making If that's the case then we can move forward with the steps that @jasongrout recommends |
Since there is general consensus so far (and one "no vote"), I went ahead and created a PR so that the Executive Council has something to vote on if they decide that this conversation can be considered "decided": |
voted, sorry for the tardiness! |
### Why split the `executablebooks/` repositories into two homes? | ||
|
||
We believe that the `executablebooks/` repositories naturally fall into two technical directions: one based on `docutils` and `sphinx` (with heavy overlap with the broader developer documentation community), and one based on Javascript (with heavy overlap with scientific computing and authoring workflows). | ||
|
||
The technical direction and user-focus of each is distinct enough that it is natural to split them into two projects. This will allow each organization to define their own set of target users and strategies to serve them. | ||
|
||
Note that, initially, the Steering Council of `executablebooks/` and that of the `jupyter-book` organization will be the same. This will allow us to coordinate the direction of projects in each organization for the immediate future, and minimize the friction associated with having two organizational homes. Over time, we intend for the strategy and governance of each organization to begin to evolve independent of one another. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ellisonbg from your question here jupyter/governance#229 (comment)
Since the vote here is unanimous for the SSC, and is unanimous over at jupyter/governance#229 for the EC, I think the motion passes, and Jupyter Book is now our newest subproject. I merged jupyter/governance#229, but I'll leave it up to someone in the SSC to merge this PR. Congratulations! |
Wow, so exciting! Thanks everybody 🙂 it has been a long road back home for the jupyter book project! |
Congrats @choldgraf @rowanc1 and everyone involved. |
Jupyter Book is now forking and eliminating support for Sphinx, Sphinx extensions, and RestructuredText in Jupyter Book 2. Jupyter Book 2 requires installing NodeJS to build Markdown (to PDFs). It was already possible to use various non-latexpdf sphinx.builder Builders to build PDFs from Sphinx docs in ReStructuredText and Markdown. This fragments the existing open ecosystem, selfishly foregoes support for lots of already-done ReStructuredText docs, and requires rewriting every Sphinx extension from Python to JS. There is a open core vendor with a product built on myst-md, which they currently contribute to, which wants this. Jupyter Book 2 certainly has the right to port away from Sphinx and all the code they've now copied. Jupyter Project certainly has the right to support whichever projects, regardless of fragmentation by (later) 'hostile' forks/clones/ports and open-core interests. I'm obviously late to committee on this. MyST Markdown (myst-md) was created to implement the Roles and Directives features of ReStructuredText (docutils). nbsphinx also allows for embedding notebooks within docs, and roles and directives docs within notebooks. Jupyter Notebook actually originally supported RST in Notebooks, but the ReStructuredText cell type was removed early on by @takluyver IIRC, IIRC due to there having been no good way to prevent arbitrary file inclusion and RST injection with the Docutils (@goodger) was moved from SourceForge to GitHub in 2015; but they didn't import Issues like @chrisjsewell's /docutils; So, Jupyter in this context means backward-incompatible fork of docutils and sphinx and restructuredtext that doesn't support Python or RST anymore? It's too late to ask for justification for backward-incompatibility and rework and fragmentation: https://executablebooks.org/en/latest/blog/2024-05-20-jupyter-book-myst/ Which of these things are within the scope of the Jupyter Project and/or the Jupyter Book project, or does there need to be another "Jupyter Book" -like project with a different name? :
How can Jupyter users continue to use myst-parser with existing Sphinx docs? |
@westurner thanks for taking the time to write down your assessment. I am not sure if commenting on this proposal vote from half a year ago will give it the best visibility, but unfortunately there is not an obvious "better" place that comes to mind, either, as Jupyter has struggled for several years now in engaging both users and contributors. |
Yes, thank you @westurner. Now that the Jupyter Book Team is formed, I would suggest using their team-compass page to raise this issue: https://github.com/jupyter-book/team-compass In principle, this is a good place to raise issues to a subprojects team members who are ultimately responsible for shepherding the project. |
This JEP proposes incorporating Jupyter Book as a Jupyter sub-project.
See the pre-proposal issue below for conversation around this:
jupyter-book
as a Jupyter sub-project #122Voting from @jupyter/software-steering-council