Update to Bokeh latest (0.12.3) and fix test plot #299
Conversation
| @@ -222,7 +222,7 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "!pip install bokeh==0.11.1" | |||
| "!pip install bokeh" | |||
There was a problem hiding this comment.
I would prefer if we keep this version scoped, to 0.12.x. It's possible that a future update (such as 0.13) could break us again.
There was a problem hiding this comment.
Agreed, I pinned to Bokeh 0.12.3.
| @@ -385,7 +386,7 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "show(p)" | |||
| "handle = show(p, notebook_handle=True)" | |||
There was a problem hiding this comment.
I pulled down the code and ran as follows:
make clean
make dev-install kernel-gateway-image examples
make dev
Now I'm getting this error in the browser console when running this dashboard:
TypeError : show() got an unexpected keyword argument 'notebook_handle'
TypeErrorTraceback (most recent call last)
<ipython-input-10-b378e9357e15> in <module>()
----> 1 handle = show(p, notebook_handle=True)
TypeError: show() got an unexpected keyword argument 'notebook_handle'
There was a problem hiding this comment.
Hmm, I only see that error with Bokeh 0.11.1. Did you update to Bokeh 0.12.3 in your environment?
There was a problem hiding this comment.
I'll give this another test on my end today.
There was a problem hiding this comment.
I do not see the error mentioned above with the new notebook. The intiial bokeh plot appears. However, the ipywidgets associated with it have no effect on its output.
|
I see in the linked issue that the fix depends on the shims that @philippjfr contributed to ipywidgets master. We can pin bokeh to 0.11 for the time being to get the demo working again if desired. We can review getting bokeh 0.12 working when ipywidgets 6.0 is out and the rest of the dashboard server works with that release (probably not a no-op). |
|
Thanks for the updates. PR #280 pinned this example notebook to Bokeh 0.11.1, so I can leave this PR open until the issue in #279 (comment) is resolved. |
Resolves #279.
Update to latest version of Bokeh 0.12.3 and fix plot in
test_plotting_libs.ipynb.