Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wasm flags #410

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Update wasm flags #410

merged 1 commit into from
Oct 16, 2024

Conversation

IsabelParedes
Copy link
Member

Fixes:

warning: use of legacy setting: TOTAL_STACK (setting renamed to STACK_SIZE) 

warning: use of legacy setting: USE_PTHREADS (No longer needed. Use -pthread instead)

By default, support for pthreads is not enabled. (source)

@IsabelParedes IsabelParedes marked this pull request as ready for review October 16, 2024 11:24
martinRenou
martinRenou approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 545df2f into jupyter-xeus:main Oct 16, 2024
10 checks passed
@IsabelParedes IsabelParedes deleted the emsdk_flags branch October 16, 2024 11:34
@SylvainCorlay
Copy link
Member

Hey @IsabelParedes do you need a release of xeus with these flags for your work on xeus-r?

@IsabelParedes
Copy link
Member Author

Hey @IsabelParedes do you need a release of xeus with these flags for your work on xeus-r?

It's not necessary. Locally, I'm building the xeus stack from source in the same environment so I can make any changes as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IsabelParedes @SylvainCorlay @martinRenou