Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experimental] async exec requests with xeus #382

Closed
wants to merge 4 commits into from

Conversation

DerThorsten
Copy link
Member

@DerThorsten DerThorsten commented Feb 16, 2024

In a nutshell:

  • new async handlers in kernel-core (atm only execute_request)

  • new xainterpreter class:

    • this is just the old interpreter class, but :
      • async_execute_request instead of execute_request method
      • async_execute_request gets a response_sender as additional argument
      • returns void instead of a reply
      • callers of async_execute_request are responsible for calling response_sender with the reply instead of returning it
  • backward compatible / should not break existing code bases:
    - new xinterpreter class deriving from the new xainterpreter having the old API

  • atm the publisher story is very hacky:

    • all the methods like "display_data" / "publish_execution_error" do not work by default because they use the wrong parent header in case of concurrent requests (jeah xeus stores parent headers in a single variable which is overwriten on concurrent requests)
    • => as a quick hack I added overloads for these methods that a parent-header can be passed but this is a bit ugly

@DerThorsten
Copy link
Member Author

#384 is using most of the ideas of this pr

@DerThorsten DerThorsten closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant