-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ErrorWidget as fallback when widgets models or views fail - Following up #3304
Merged
martinRenou
merged 14 commits into
jupyter-widgets:master
from
trungleduc:feat_error_widget
Nov 23, 2021
Merged
ErrorWidget as fallback when widgets models or views fail - Following up #3304
martinRenou
merged 14 commits into
jupyter-widgets:master
from
trungleduc:feat_error_widget
Nov 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build extension failed because the Jupyterlab |
This makes sure that we always render something, with a descriptive error message. This makes is easier for users to diagnose or report issues.
martinRenou
reviewed
Nov 9, 2021
vidartf
reviewed
Nov 9, 2021
Note: I made a half-baked backport of this PR to the 7.x branch for private needs, putting the link here in case we need it later. Meeseeks will not be able to backport it automatically. |
martinRenou
reviewed
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Initially started in #2960 by @maartenbreddels, this PR resolves the conflicts in #2960 and updates the behavior of the failback widget.
Code changes
loadModelClass
andloadViewClass
logic on old PR, this PR adds some moretry-catch
blocks to catch the errors in model creation or view rendering.User-facing changes
138243743-34a49956-6d54-4aab-ba7d-12713a12c762.mp4
Backwards-incompatible changes
N/A