Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cell execution_state #197

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

davidbrochart
Copy link
Collaborator

Closes #169

Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, especially given that jupyterlab/jupyterlab#16431 moves in this direction.

I think that merging this one does not preclude #227 from being merged.

Can we standardize that allowed values are running (or executing) and idle?

I would like to avoid using busy here as "busy" represents a couple of sub-states (like executing, pending-input, queued). Of note jupyterlab/jupyterlab#16431 used running but it was not released yet so we are not bound to it.

@davidbrochart
Copy link
Collaborator Author

Can we standardize that allowed values are running (or executing) and idle?

Actually only "idle" is used in this PR. I will rebase it.

@krassowski
Copy link
Collaborator

Yes, what I meant is that we probably should have some place to store source of truth for the enum values, this does not have to be addressed in this PR but would be good to settle on something soon.

@krassowski
Copy link
Collaborator

I think this one is good to merge 🎉

@krassowski
Copy link
Collaborator

Shall we merge this?

@krassowski
Copy link
Collaborator

Hearing no objections I am going to merge this one :)

@krassowski krassowski merged commit 16162f9 into jupyter-server:main Aug 6, 2024
10 checks passed
@krassowski
Copy link
Collaborator

I will publish 3.0.0a3 now to integrate this with JupyterLab and jupyter-server-nbmodel

@krassowski
Copy link
Collaborator

It looks like do not have sufficient rights to release (https://github.com/jupyter-server/jupyter_ydoc/actions/runs/10282910526/job/28455597267) @davidbrochart are you able to help here?

RuntimeError: Could not get user permission level, assuming user was not admin!

@krassowski
Copy link
Collaborator

I opened follow-up #259

@davidbrochart
Copy link
Collaborator Author

@davidbrochart are you able to help here?

Sorry I'm off with a very limited access to Internet, I'll look at that in a week or so.

@krassowski
Copy link
Collaborator

krassowski commented Aug 7, 2024

No worries, I will try asking someone else on the server meeting tomorrow to get rights to release. Are you able to get a quick look at #259 so that I could release that in an alpha to unblock jupyterlab/jupyterlab#16651?

@davidbrochart
Copy link
Collaborator Author

Are you able to get a quick look at #259

Done, let me try and release 3.0.0a3.

@davidbrochart
Copy link
Collaborator Author

Looks like 3.0.0a3 is out, but yes you should ask for release rights (I don't think I can give them to you).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook cell execution
2 participants