-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure terminal cwd exists #755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
You can run pre-commit now with meeseeks - "please pre-commit" |
Codecov Report
@@ Coverage Diff @@
## main #755 +/- ##
==========================================
- Coverage 70.68% 70.56% -0.12%
==========================================
Files 62 62
Lines 7620 7627 +7
Branches 1218 1220 +2
==========================================
- Hits 5386 5382 -4
- Misses 1860 1877 +17
+ Partials 374 368 -6
Continue to review full report at Codecov.
|
Thanks @blink1073 - I was lazy and use github.dev instead of my local clone 😉 Windows tests are failing due to the project being checkout on a different drive than the one the server is running in. Switching to draft for now. |
it is removed in ServerApp from the root directory
I don't know if the culling test are known to be flaky |
Yes, cf #677 |
Thanks @blink1073 then I guess this is ready. |
I'm still concerned about the Minimum Version test failure. I'll kick all of the jobs once the current GitHub outage incident is resolved. |
CI failure is due to jinja2 3.1 release that removed deprecated method contextfilter. This is breaking nbconvert. |
Kicking to pick up fixes from other PRs. |
Failing test is unrelated, thanks! |
Check that the terminal current working directory exists. If it does not test if it is relative to the server root directory otherwise ignore it.
Follow-up of #749