Authorization #467
Closed
Authorization #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! What are the plans with this? |
|
I see on the previous Pr comments like https://github.com/jupyter-server/jupyter_server/pull/165/files#r364461658 - would be good to not forget them |
I think Zach's PR was a nice solution for supporting authorization, should we push it forward? |
|
Given the original PR is marked WIP could we discuss this at tomorrow's server dev meeting before moving forward? We may also want to look at rebasing on the original PR so as to preserve comment history. |
|
I can join the meeting and discuss this PR and Zach's original plans. |
|
I pushed this PR back to Zach's original PR #165, we'll work there from now on, at least to keep it up to date in case we want to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of @Zsailer's PR #165