-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disk monitoring #233
Add disk monitoring #233
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
@krassowski Would you be able to add the correct label(s)? |
@krassowski (and other contrib's) what would help get this across the line? |
My project has been using these changes in production for nearly a month now. |
Co-authored-by: Michał Krassowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestions/questions, a few typos in the documentation to fix, otherwise it looks good to me.
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
@krassowski I've made those suggested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @iandesj!
@iandesj, @perllaghu - this is now released with https://github.com/jupyter-server/jupyter-resource-usage/releases/tag/v1.1.0 available on PyPI now and some time later on conda-forge 🎉 |
Excellent - many thanks. |
This is continuation of what #232 is trying to enhance!
Additionally, this PR: