Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk monitoring #233

Merged
merged 23 commits into from
Jul 31, 2024
Merged

Conversation

iandesj
Copy link
Contributor

@iandesj iandesj commented Apr 26, 2024

This is continuation of what #232 is trying to enhance!

Additionally, this PR:

  • Fixes computing the disk warning state
  • Propagates all resources in warning, not just memory
  • Tweaks the react condition to look at all warnings

Copy link

welcome bot commented Apr 26, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@iandesj
Copy link
Contributor Author

iandesj commented Apr 26, 2024

@krassowski Would you be able to add the correct label(s)?

@iandesj
Copy link
Contributor Author

iandesj commented Apr 30, 2024

@krassowski (and other contrib's) what would help get this across the line?

@iandesj iandesj mentioned this pull request May 22, 2024
@iandesj
Copy link
Contributor Author

iandesj commented Jun 3, 2024

My project has been using these changes in production for nearly a month now.

Co-authored-by: Michał Krassowski <[email protected]>
@iandesj iandesj requested a review from krassowski June 20, 2024 17:48
Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestions/questions, a few typos in the documentation to fix, otherwise it looks good to me.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jupyter_resource_usage/api.py Outdated Show resolved Hide resolved
iandesj and others added 4 commits July 30, 2024 10:44
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
@iandesj iandesj requested a review from krassowski July 30, 2024 17:37
@iandesj
Copy link
Contributor Author

iandesj commented Jul 30, 2024

@krassowski I've made those suggested changes

Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iandesj!

@krassowski krassowski merged commit 41d88a2 into jupyter-server:main Jul 31, 2024
13 checks passed
@krassowski
Copy link
Collaborator

@iandesj, @perllaghu - this is now released with https://github.com/jupyter-server/jupyter-resource-usage/releases/tag/v1.1.0 available on PyPI now and some time later on conda-forge 🎉

@perllaghu
Copy link
Contributor

Excellent - many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants