Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear state when switching away, add blank state indicator #178

Merged
merged 7 commits into from
Feb 20, 2023

Conversation

krassowski
Copy link
Collaborator

Addresses #172 (comment):

  • clear kernel usage state when switching away by listening to shell.activChanged when in JupyterLab
  • implement informative blank state in place of incorrect "not available" blanket statments
  • handle timeout (preserve old usage for reference but grey them out and show that timeout occurred)
  • check delayed replies to prevent displaying outdated state for a previous notebook
  • support consoles (as a bonus)

Demonstration of the new behaviour:

kernel-usage-new-blank-indicator

@welcome
Copy link

welcome bot commented Feb 19, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski krassowski added the bug label Feb 19, 2023
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 143f456 into jupyter-server:main Feb 20, 2023
@welcome
Copy link

welcome bot commented Feb 20, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants