Resolve periodic socket.timeout causing control channel socket recycling #1381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every message send from the Enterprise Gateway to the kernel, a new connection is accepted using
socket.accept()
. The timeout for this socket is 5 seconds:enterprise_gateway/etc/kernel-launchers/python/scripts/launch_ipykernel.py
Line 293 in d01e84a
Instead of restarting the blocking
accept
call, we can useselect.select
to check ready-state of the socket. Using this method we don't cycle the connection and delay (or miss) messages.