Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update crictl version from v1.21.0 to v1.24.0 #1364

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

mmmommm
Copy link
Contributor

@mmmommm mmmommm commented Jan 30, 2024

relate: #1363

This is Independently upgrade cri-tools to v1.24.0 or higher solution.

I am trying to pull from a private registry using the CRICTL_AUTH environment variable. However, this feature is only available in crictl (cri-tools) versions v1.24.0 and above.
Currently, I am using v1.21.0 which is related to the OS version.

@kevin-bates
Copy link
Member

Hi @mmmommm - thank you for the issue and subsequent pull request - I apologize for the lack of response.

Since we're talking only about the KIP image and assuming it would make on-going maintenance easier over installing an explicit version of crictl, I'd be in favor of moving to Debian 12 instead (as I believe you prefer). Would you mind pivoting to that approach?

@mmmommm
Copy link
Contributor Author

mmmommm commented Feb 2, 2024

@kevin-bates

Thank you for your response.

I'd be in favor of moving to Debian 12 instead

Of course, I agree with pivoting this pr to move to Debian 12 👍

@mmmommm
Copy link
Contributor Author

mmmommm commented Feb 2, 2024

It seems the operation is working without any issues.

$ cd ./etc/docker/kernel-image-puller
$ docker build  -t kernel-image-puller .
[+] Building 54.8s (25/25) FINISHED 
####################### Responses for command execution are being truncated.

$ docker run -d --name kip kernel-image-puller&& docker exec kip crictl -v
0d426a1de30e7cf6814f5266e23a88efc7132b7d5732cb0894c9592019be738a
crictl version v1.26.0

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @mmmommm!

@kevin-bates kevin-bates merged commit 7ab3ebe into jupyter-server:main Feb 3, 2024
13 of 14 checks passed
Copy link

welcome bot commented Feb 3, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@mmmommm mmmommm deleted the update_critools_version branch February 5, 2024 01:12
@mmmommm
Copy link
Contributor Author

mmmommm commented Feb 5, 2024

@kevin-bates
I have a question, when do you think we will be able to use the fixed image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants