-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new WebhookKernelSessionManager for Kernel Persistence #1101
Conversation
This is very interesting @amazingarman! I find this to be a clever (and flexible) way to integrate with a persistent store of any kind. Very nice. Here are some next steps that should probably be included in this pull request.
On that "modes" topic, this PR implies you must be using some form of availability and I'm curious what your thoughts are about where we're headed with that? What kinds of issues are you running into with the current code base? (Mostly curious about re-connects and culling, but any other experiences would be very helpful.) |
for more information, see https://pre-commit.ci
@kevin-bates updated the PR based off of your comments.
I agree that the version info in the URL is up to the provider to figure out.
I don't have any availability set up currently and in the early stages of building this out. The modes PR is something that will definitely be used and agree on the direction it seems to be heading in. The code base is easy to read and follow, although the documentation is sparse in areas. We found solutions reading through past PRs and Issues raised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amazingarman - thanks so much for the update. There are just a few minor touchups necessary, but this looks good!
We will have some heavy overlap with the documentation in #1095, but I'm happy to tackle that once this PR is merged (following the additional updates).
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amazingarman - Thank you for the updates and this nice feature!
Will merge Friday morning barring any objections. |
Added a new way to persist kernels to any database. You must create an API to interact with your database. The API should have 4 endpoints:
In order to setup the WebhookKernelSessionManager, you must set
--EnterpriseGatewayApp.kernel_session_manager_class
toenterprise_gateway.services.sessions.kernelsessionmanager.WebhookKernelSessionManager
,--WebhookKernelSessionManager.webhook_url
to the endpoint url of your API and--WebhookKernelSessionManager.enable_persistence=True
to enable kernel persistence.