Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Apply alignment style #17

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Feat: Apply alignment style #17

merged 1 commit into from
Apr 25, 2024

Conversation

jiaojiaojiaoCpbr
Copy link
Collaborator

@jiaojiaojiaoCpbr jiaojiaojiaoCpbr commented Apr 24, 2024 •
edited
Loading

Pull Request Title 請加上 prefix，e.g. New:/Fix:/Change:/Refactor:/Chore:/Test:/Doc: ...

Notion Link:

https://www.notion.so/junyiacademy/perseus-css-a0540a1ebe4f4906be6839bb9d748194

Introduction

請說明此 Pull Request 的目的

  • 把 alignment 的 style 直接在元件中實作

How to verify

請說明如何驗證此 Pull Request 的改動可以達成目的（或是做過哪些驗證）

  • 安裝 [email protected] 以上
  • 傳 defaultAlignment 給 widget，可以套用相對應的 display property

@jiaojiaojiaoCpbr jiaojiaojiaoCpbr added 🔧 publish-npm Add this tag will publish perseus-core to npm and removed 🔧 publish-npm Add this tag will publish perseus-core to npm labels Apr 24, 2024
@NG-KWAN-LOK NG-KWAN-LOK self-requested a review April 25, 2024 03:31
@NG-KWAN-LOK NG-KWAN-LOK removed their request for review April 25, 2024 03:32
@NG-KWAN-LOK NG-KWAN-LOK removed their assignment Apr 25, 2024
@NG-KWAN-LOK NG-KWAN-LOK self-requested a review April 25, 2024 03:32
@NG-KWAN-LOK NG-KWAN-LOK self-assigned this Apr 25, 2024
NG-KWAN-LOK
NG-KWAN-LOK approved these changes Apr 25, 2024
View reviewed changes
Copy link

@NG-KWAN-LOK NG-KWAN-LOK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM r+

@jiaojiaojiaoCpbr jiaojiaojiaoCpbr merged commit c0eff8f into main Apr 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NG-KWAN-LOK NG-KWAN-LOK NG-KWAN-LOK approved these changes

Assignees

@NG-KWAN-LOK NG-KWAN-LOK

@jiaojiaojiaoCpbr jiaojiaojiaoCpbr

Labels
🔧 publish-npm Add this tag will publish perseus-core to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiaojiaojiaoCpbr @NG-KWAN-LOK