Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: type error of getPublicWidgets #13

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix: type error of getPublicWidgets #13

merged 1 commit into from
Mar 25, 2024

Conversation

esp10mm
Copy link

@esp10mm esp10mm commented Mar 25, 2024

Pull Request Title 請加上 prefix，e.g. New:/Fix:/Change:/Refactor:/Chore:/Test:/Doc: ...

Notion Link:

Introduction

請說明此 Pull Request 的目的

  • 本來 getPublicWidgets 定義的 type 是陣列，但實際上是 Record，所以發此 PR 修改

How to verify

請說明如何驗證此 Pull Request 的改動可以達成目的（或是做過哪些驗證）

  • 主站使用時沒有 typescript error

@esp10mm esp10mm added the 🔧 publish-npm Add this tag will publish perseus-core to npm label Mar 25, 2024
@Kim716 Kim716 merged commit 155f131 into main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔧 publish-npm Add this tag will publish perseus-core to npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esp10mm @Kim716