Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drill widgetGroupId for scoring grouped widgets #10

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

jiaojiaojiaoCpbr
Copy link
Collaborator

@jiaojiaojiaoCpbr jiaojiaojiaoCpbr commented Mar 5, 2024

Pull Request Title 請加上 prefix,e.g. New:/Fix:/Change:/Refactor:/Chore:/Test:/Doc: ...

Notion Link:

https://www.notion.so/junyiacademy/fa83086f063a4d9ab504e86fc369b1d1

Introduction

請說明此 Pull Request 的目的

  • <Renderer /> 將 widgetGroupId 傳遞給 widget,讓 grouped widgets(如:draggable container)可以整組被驗證分數

How to verify

請說明如何驗證此 Pull Request 的改動可以達成目的(或是做過哪些驗證)

  • widget 有辦法接收到 widgetGroupId

@jiaojiaojiaoCpbr jiaojiaojiaoCpbr self-assigned this Mar 6, 2024
@jiaojiaojiaoCpbr jiaojiaojiaoCpbr added the 🔧 publish-npm Add this tag will publish perseus-core to npm label Mar 6, 2024
@jiaojiaojiaoCpbr jiaojiaojiaoCpbr added 🔧 publish-npm Add this tag will publish perseus-core to npm and removed 🔧 publish-npm Add this tag will publish perseus-core to npm labels Mar 6, 2024
@jiaojiaojiaoCpbr jiaojiaojiaoCpbr requested a review from esp10mm March 6, 2024 11:21
@jiaojiaojiaoCpbr jiaojiaojiaoCpbr added 🔧 publish-npm Add this tag will publish perseus-core to npm and removed 🔧 publish-npm Add this tag will publish perseus-core to npm labels Mar 7, 2024
@jiaojiaojiaoCpbr jiaojiaojiaoCpbr merged commit 3026935 into main Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 publish-npm Add this tag will publish perseus-core to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants