forked from Khan/perseus
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Delete unused code from tex.ts (Khan#927)
## Summary: There was a lot of code in this file related to our old KaTeX+MathJax2 renderer. Now that we have switched to MathJax 3, we can simplify things. I've also deleted a couple functions that simply weren't used anywhere. I changed the type of `processMath`'s `text` param to `string | number` because the code that generates Graphie labels sometimes passes a number. Issue: none Test plan: Review storybook stories that use TeX labels: - Grapher widget - Interactive Graph widget - Number Line widget The graph labels should display in the correct place. Author: benchristel Reviewers: benchristel, jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage, ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Extract i18n strings (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: Khan#927
- Loading branch information
1 parent
4c2c2ab
commit 1e17919
Showing
7 changed files
with
160 additions
and
656 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@khanacademy/perseus": patch | ||
--- | ||
|
||
Remove unused code related to KaTeX and MathJax 2. It's no longer needed | ||
because all callers have upgraded to MathJax 3. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.