Feature: Responsive media component #45
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,9 +4,9 @@ module.exports = withHelpers(async (migration, _context, helpers) => { | |
| const defaultLocale = await helpers.locale.getDefaultLocale(); | ||
|
|
||
| const cMedia = migration | ||
| .createContentType('c-responsive-media') | ||
| .name('Component: Responsive media') | ||
| .description('Image or short loop video for different screen sizes') | ||
| .displayField('internal_name'); | ||
|
|
||
| cMedia | ||
|
|
@@ -23,25 +23,15 @@ module.exports = withHelpers(async (migration, _context, helpers) => { | |
| .createField('alt') | ||
| .name('Alt text') | ||
| .type('Symbol') | ||
| .localized(true) | ||
| .required(true) | ||
| .validations([]) | ||
| .disabled(false) | ||
| .omitted(false); | ||
|
|
||
| cMedia | ||
| .createField('mobile_media') | ||
| .name('Mobile > Media') | ||
| .type('Link') | ||
| .localized(true) | ||
| .required(true) | ||
|
|
@@ -56,35 +46,21 @@ module.exports = withHelpers(async (migration, _context, helpers) => { | |
|
|
||
| cMedia | ||
| .createField('mobile_ratio') | ||
| .name('Mobile > Ratio') | ||
| .type('Symbol') | ||
| .localized(false) | ||
| .required(false) | ||
| .validations([ | ||
| { | ||
| in: ['1x1', '16x9', '9x16', '4x3', '3x4'], | ||
|
There was a problem hiding this comment. Definitely the better naming and more obviously 👍 There was a problem hiding this comment. I think so too. 👍 Unfortunately, there is still a bug in Sonar that I don't exactly understand yet. I'll have a look. https://sonarcloud.io/project/issues?resolved=false&types=BUG&pullRequest=45&id=jungvonmatt_create-contentful-hugo-app&open=AYNg2o7ptY5uRUoaXYTE There was a problem hiding this comment. Sounds like sonar thinks that this is a mathematical expression and you just could write 1, I guess.. There was a problem hiding this comment. Thanks @dlemm, that solved it. |
||
| }, | ||
| ]) | ||
| .disabled(false) | ||
| .omitted(false); | ||
|
|
||
| cMedia | ||
| .createField('mobile_focus_area') | ||
| .name('Mobile > Focus area') | ||
| .type('Symbol') | ||
| .localized(false) | ||
| .required(false) | ||
|
|
@@ -112,8 +88,8 @@ module.exports = withHelpers(async (migration, _context, helpers) => { | |
| .omitted(false); | ||
|
|
||
| cMedia | ||
| .createField('desktop_media') | ||
| .name('Desktop > Media') | ||
| .type('Link') | ||
| .localized(true) | ||
| .required(false) | ||
|
|
@@ -127,49 +103,47 @@ module.exports = withHelpers(async (migration, _context, helpers) => { | |
| .linkType('Asset'); | ||
|
|
||
| cMedia | ||
| .createField('desktop_ratio') | ||
| .name('Desktop > Ratio') | ||
| .type('Symbol') | ||
| .localized(false) | ||
| .required(false) | ||
| .validations([ | ||
| { | ||
| in: ['1x1', '16x9', '9x16', '4x3', '3x4'], | ||
| }, | ||
| ]) | ||
| .disabled(false) | ||
| .omitted(false); | ||
|
|
||
| cMedia | ||
| .createField('desktop_focus_area') | ||
| .name('Desktop > Focus area') | ||
| .type('Symbol') | ||
| .localized(false) | ||
| .required(false) | ||
| .validations([ | ||
| { | ||
| in: [ | ||
| 'center', | ||
| 'top', | ||
| 'bottom', | ||
| 'right', | ||
| 'left', | ||
| 'top_right', | ||
| 'top_left', | ||
| 'bottom_right', | ||
| 'bottom_left', | ||
| 'face', | ||
| 'faces', | ||
| ], | ||
| }, | ||
| ]) | ||
| .defaultValue({ | ||
| [defaultLocale.code]: 'center', | ||
| }) | ||
| .disabled(false) | ||
| .omitted(false); | ||
|
|
||
| cMedia | ||
| .createField('lazy') | ||
|
|
@@ -185,49 +159,32 @@ module.exports = withHelpers(async (migration, _context, helpers) => { | |
| .omitted(true); | ||
|
|
||
| cMedia.changeFieldControl('internal_name', 'builtin', 'singleLine', { | ||
| helpText: 'e.g. "Home page > Media > Responsive media"', | ||
| }); | ||
|
|
||
| cMedia.changeFieldControl('alt', 'builtin', 'singleLine', {}); | ||
|
|
||
| cMedia.changeFieldControl('mobile_media', 'builtin', 'assetLinkEditor', {}); | ||
|
|
||
| cMedia.changeFieldControl('mobile_focus_area', 'builtin', 'dropdown', { | ||
| helpText: 'Choose a focus area that will be used for resizing. Default is "center".', | ||
| }); | ||
|
|
||
| cMedia.changeFieldControl('mobile_ratio', 'builtin', 'dropdown', { | ||
| helpText: 'Select a ratio for mobile or leave empty to use original image dimensions.', | ||
| }); | ||
|
|
||
| cMedia.changeFieldControl('desktop_media', 'builtin', 'assetLinkEditor', { | ||
| helpText: | ||
| 'Can be used to use different ratios on mobile and desktop. If empty, the mobile media will be used for both.', | ||
| }); | ||
|
|
||
| cMedia.changeFieldControl('desktop_ratio', 'builtin', 'dropdown', { | ||
| helpText: 'Select a ratio for desktop. Leave empty to use original media dimensions.', | ||
| }); | ||
|
|
||
| cMedia.changeFieldControl('desktop_focus_area', 'builtin', 'dropdown', { | ||
| helpText: 'Choose a focus area that will be used for resizing. Default is "center".', | ||
| }); | ||
|
|
||
| cMedia.changeFieldControl('lazy', 'builtin', 'boolean', {}); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we needed it because with different ratios the sizes come from the
<source>elements. Maybe it is enough there. But I just noticed another problem, there is a layout shift when the sources have a media attribute. I am looking for a solution.