-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm publish workflow #2
base: master
Are you sure you want to change the base?
Conversation
We should also add the dependabot integration to this repo, it'll create a new PR to every new release of the dependencies used in the The coolest thing is that we're able to add reviewers to avoid breaking changes when merging these updates, and other kinds of stuff, like labels. |
.github/workflows/npm-publish.yaml
Outdated
- name: Install dependencies | ||
run: yarn install | ||
|
||
- name: Build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we missing a bump step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I'll add it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 6a7e668
47e7be8
to
102fb36
Compare
Flux:
|
Isn't it better to publish to NPM when there is a new release? So we have better control over our publish and over our versions. For example if we have 2 MRs ready to be merged, we don't need to send 2 new versions to NPM, we may want to release them together. |
- name: Set up Node.js | ||
uses: actions/setup-node@master | ||
with: | ||
node-version: 10.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use node 12?
The workflow that will publish the package will only run after a
We also would need to have a branch for staging, in order to merge the pull requests of |
This PR adds a github actions workflow to publish the package to NPM on every new release.
We would just need to worry about bumping the version and then creating a new release. The workflow will run the steps to make sure that the build is working as expected and publish it to NPM.