Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lease_name parameter to ListenRequest #14

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Add lease_name parameter to ListenRequest #14

merged 2 commits into from
Oct 11, 2024

Conversation

NickCao
Copy link
Collaborator

@NickCao NickCao commented Oct 11, 2024

No description provided.

mangelajo
mangelajo approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@mangelajo mangelajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our matrix conversation, this makes sense to better control the stream listening lifecycle in the exporter.

mangelajo
mangelajo approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@mangelajo mangelajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the new commit too :)

@NickCao NickCao merged commit 21332c4 into main Oct 11, 2024
1 check passed
@NickCao NickCao deleted the listen-lease branch October 11, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangelajo mangelajo mangelajo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickCao @mangelajo