Add simple SOS decomposition example #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a trivial SOS decomposition example in response to issue #166 (comment) It is simple but hopefully clearer than a docstring.
blegat
reviewed
Aug 7, 2020
examples/sos_decomposition.jl
Outdated
| # ------------------------------------------------------------------------------ | ||
|
|
||
| # The polynomial p = x^2 - x*y^2 + y^4 + 1 is SOS. | ||
| # Among infinite others, it has the decomposition: |
There was a problem hiding this comment.
What do you mean by "Among infinite others" ? Isn't it the only polynomial with this decomposition ?
blegat
reviewed
Aug 7, 2020
Express the opening note more clearly. Remove unnecessary `SumOfSquares.` prefix.
|
Does this update resolve the issues? |
blegat
reviewed
Aug 7, 2020
examples/sos_decomposition.jl
Outdated
| # Among infinite others, it has the decomposition: | ||
| # p = 3/4*(x-y^2)^2 + 1/4*(x + y)^2 + 1. | ||
| # We can, for example, decompose it as | ||
| # p = 3/4*(x-y^2)^2 + 1/4*(x + y)^2 + 1, |
| using SumOfSquares | ||
| using JuMP | ||
| using SCS | ||
|
|
There was a problem hiding this comment.
Can you add your name here after **Contributed by**: ? This is not done for other notebboks yet but I am reworking them at the moment
Sign header. Format polynomial in comment.
|
Sure, does username suffice as a signature? |
blegat
approved these changes
Aug 8, 2020
Yes, as you prefer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a trivial SOS decomposition example in response to issue #166 (comment)
It is simple but hopefully clearer than a docstring.