Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect query of multiplicative duals and fix objective term on duals #138

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

joaquimg
Copy link
Member

@joaquimg joaquimg commented Oct 23, 2023

Close #133
cc @sstroemer

@joaquimg joaquimg changed the title Protect query of multiplicative duals Protect query of multiplicative duals and fix objective term on duals Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da2c498) 95.15% compared to head (26f0bdc) 95.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   95.15%   95.26%   +0.10%     
==========================================
  Files           4        4              
  Lines        1033     1034       +1     
==========================================
+ Hits          983      985       +2     
+ Misses         50       49       -1     
Files Coverage Δ
src/duals.jl 100.00% <100.00%> (+1.56%) ⬆️
src/utils.jl 99.30% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquimg joaquimg merged commit c0e8af9 into master Oct 23, 2023
7 checks passed
@joaquimg joaquimg deleted the jg/multparamerr branch October 23, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Getting proper ParameterDuals
1 participant